Include dir support for diagnostics

lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java

@@ -55,6 +55,10 @@ public class LibertyDiagnosticParticipant implements IDiagnosticsParticipant {
     public static final String IMPLICIT_NOT_OPTIONAL_MESSAGE = "The specified resource cannot be skipped. Check location value or add optional attribute.";
     public static final String IMPLICIT_NOT_OPTIONAL_CODE = "implicit_not_optional";
 
+    public static final String SPECIFIED_DIR_IS_FILE = "Path specified a directory, but resource exists as a file.";
+    public static final String SPECIFIED_FILE_IS_DIR = "Path specified a file, but resource exists as a directory.";
+    public static final String FILETYPE_MISMATCH_CODE = "filetype_mismatch";
+
     public static final String INCORRECT_FEATURE_CODE = "incorrect_feature";
 
     private Set<String> includedFeatures;
@@ -150,11 +154,14 @@ private void validateIncludeLocation(DOMDocument domDocument, List<Diagnostic> d
         if (locAttribute.startsWith("http") || locAttribute.contains("$")) {
             return;
         }
+        // Liberty uses this to determine if directory. 
+        boolean isLibertyDirectory = locAttribute.endsWith("/") || locAttribute.endsWith(File.separator);
 
         DOMNode locNode = node.getAttributeNode("location");
         Range range = XMLPositionUtility.createRange(locNode.getStart(), locNode.getEnd(), domDocument);
-        if (!locAttribute.endsWith(".xml")) {
-            String message = "The specified resource is not an XML file.";
+        if (!locAttribute.endsWith(".xml")
+         && !isLibertyDirectory) {
+            String message = "The specified resource is not an XML file or directory.";
             diagnosticsList.add(new Diagnostic(range, message, DiagnosticSeverity.Warning, LIBERTY_LEMMINX_SOURCE));
             return;
         }
@@ -175,11 +182,28 @@ private void validateIncludeLocation(DOMDocument domDocument, List<Diagnostic> d
                 }
                 diagnosticsList.add(new Diagnostic(range, MISSING_FILE_MESSAGE, DiagnosticSeverity.Warning, LIBERTY_LEMMINX_SOURCE, MISSING_FILE_CODE));
             }
+            validateFileOrDirIncludeLocation(configFile, isLibertyDirectory, range, diagnosticsList);
         } catch (IllegalArgumentException e) {
             diagnosticsList.add(new Diagnostic(range, MISSING_FILE_MESSAGE, DiagnosticSeverity.Warning, "liberty-lemminx-exception", MISSING_FILE_CODE));
         }
     }
 
+    /**
+     * Checks if specified file or dir is the correct filetype.
+     * Adds diagnostics if it is mismatched.
+     * @param f - <include> location file
+     * @param isLibertyDirectory - whether Liberty considers this specified as a dir (path ends in slash)
+     * @param range - Range to apply diagnostic message
+     * @param diagnosticsList
+     */
+    private void validateFileOrDirIncludeLocation(File f, boolean isLibertyDirectory, Range range, List<Diagnostic> diagnosticsList) {
+        if (f.isFile() && isLibertyDirectory) {
+            diagnosticsList.add(new Diagnostic(range, SPECIFIED_DIR_IS_FILE, DiagnosticSeverity.Error, LIBERTY_LEMMINX_SOURCE, FILETYPE_MISMATCH_CODE));
+        } else if (f.isDirectory() && !isLibertyDirectory) {
+            diagnosticsList.add(new Diagnostic(range, SPECIFIED_FILE_IS_DIR, DiagnosticSeverity.Error, LIBERTY_LEMMINX_SOURCE, FILETYPE_MISMATCH_CODE));
+        }
+    }
+
     /**
      * Create temporary diagnostics for validation for single pass-through.
      * @param domDocument

lemminx-liberty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDocumentLinkParticipant.java

@@ -27,9 +27,9 @@
 import org.eclipse.lsp4j.DocumentLink;
 import org.eclipse.lsp4j.Range;
 
+import io.openliberty.tools.langserver.lemminx.util.LibertyConstants;
 import io.openliberty.tools.langserver.lemminx.util.LibertyUtils;
 
-
 public class LibertyDocumentLinkParticipant implements IDocumentLinkParticipant {
 
     private static final Logger LOGGER = Logger.getLogger(LibertyDocumentLinkParticipant.class.getName());
@@ -43,7 +43,7 @@ public void findDocumentLinks(DOMDocument document, List<DocumentLink> links) {
         List<DOMNode> nodes = document.getDocumentElement().getChildren();
 
         // collect all <include> nodes that are children of the document element
-        List<DOMNode> includeDomNodes = nodes.stream().filter(n -> ((n.getNodeName() != null) && n.getNodeName().equals("include")))
+        List<DOMNode> includeDomNodes = nodes.stream().filter(n -> ((n.getNodeName() != null) && n.getNodeName().equals(LibertyConstants.INCLUDE_ELEMENT)))
                 .collect(Collectors.toList());
 
         for (DOMNode includeNode : includeDomNodes) {

lemminx-liberty/src/test/java/io/openliberty/LibertyDiagnosticTest.java

@@ -158,6 +158,8 @@ public void testDiagnosticsForInclude() throws IOException {
                 "            optional=\"true\" location=\"MULTI LINER\"/>", //
                 "    <include optional=\"false\" location=\"MISSING FILE.xml\"/>", //
                 "    <include location=\"MISSING FILE.xml\"/>", //
+                "    <include location=\"/empty_server.xml/\"/>", //
+                "    <include location=\"/testDir.xml\"/>", //
                 "</server>"
         );
 
@@ -169,11 +171,11 @@ public void testDiagnosticsForInclude() throws IOException {
 
         Diagnostic not_xml = new Diagnostic();
         not_xml.setRange(r(3, 29, 3, 52));
-        not_xml.setMessage("The specified resource is not an XML file.");
+        not_xml.setMessage("The specified resource is not an XML file or directory.");
 
         Diagnostic multi_liner = new Diagnostic();
         multi_liner.setRange(r(5, 28, 5, 50));
-        multi_liner.setMessage("The specified resource is not an XML file.");
+        multi_liner.setMessage("The specified resource is not an XML file or directory.");
 
         Diagnostic not_optional = new Diagnostic();
         not_optional.setRange(r(6, 13, 6, 29));
@@ -195,9 +197,20 @@ public void testDiagnosticsForInclude() throws IOException {
         missing_xml2.setCode("missing_file");
         missing_xml2.setMessage("The resource at the specified location could not be found.");
 
+        // test dir not file? might be hard to test...
+        Diagnostic dirIsFile = new Diagnostic();
+        dirIsFile.setRange(r(8, 13, 8, 42));
+        dirIsFile.setCode("filetype_mismatch");
+        dirIsFile.setMessage("Path specified a directory, but resource exists as a file.");
+
+        Diagnostic fileIsDir = new Diagnostic();
+        fileIsDir.setRange(r(9, 13, 9, 36));
+        fileIsDir.setCode("filetype_mismatch");
+        fileIsDir.setMessage("Path specified a file, but resource exists as a directory.");
 
         XMLAssert.testDiagnosticsFor(serverXML, null, null, serverXMLFile.toURI().toString(), 
-                not_xml, multi_liner, not_optional, missing_xml, optional_not_defined, missing_xml2);
+                not_xml, multi_liner, not_optional, missing_xml, optional_not_defined, missing_xml2,
+                dirIsFile, fileIsDir);
     }
 
     @Test