Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include dir support for diagnostics #238

Merged
merged 13 commits into from
Dec 5, 2023
Merged

Include dir support for diagnostics #238

merged 13 commits into from
Dec 5, 2023

Conversation

evie-lau
Copy link
Member

@evie-lau evie-lau commented Oct 27, 2023 •
edited
Loading

Resolves #204

  • Modify behavior to allow recognizing directories
  • Validate and add diagnostics for file/dir mismatch
  • Add new diagnostic cases to tests
  • Add quickfixes for file/dir mismatch diagnostics
  • Add quickfix tests

TODO: change this PR's merge target from main to something like a nextFixRelease branch to avoid adding to 23.0.12 release

@evie-lau evie-lau requested a review from cherylking October 30, 2023 15:33
@evie-lau evie-lau marked this pull request as ready for review October 30, 2023 15:33
cherylking
cherylking requested changes Oct 31, 2023
View reviewed changes
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/LibertyDiagnosticParticipant.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddTrailingSlash.java Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddTrailingSlash.java Outdated Show resolved Hide resolved
...erty/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/AddTrailingSlash.java Outdated Show resolved Hide resolved
...y/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/RemoveTrailingSlash.java Show resolved Hide resolved
...y/src/main/java/io/openliberty/tools/langserver/lemminx/codeactions/RemoveTrailingSlash.java Outdated Show resolved Hide resolved
cherylking
cherylking reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I approve, but not adding official approval since this cannot be merged yet. Either we need a separate branch for the next fix release, or we just wait until 2.1 has been published.

cherylking
cherylking approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now that the Liberty Tools 23.0.12 release is published.

@evie-lau evie-lau merged commit b6c0eb4 into OpenLiberty:main Dec 5, 2023
4 checks passed
@evie-lau evie-lau deleted the includeDirSupport branch December 5, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider changes needed to handle new possibility of server config <include> elements pointing to a directory
2 participants
@evie-lau @cherylking