-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature generation and dev mode, build file modified integration test fix #1409
Conversation
MultiModuleUpdatePomsTest is passing locally but failing through GitHub actions, investigating. |
Test failures seem to be due to timing issues on dev mode startup, and when files are compiled. Generate features should be skipped for the initial compile that occurs once we enter the dev mode inner loop. Initial compile:
Then, on my local machine:
However on machines through GH actions the timing is slightly off where it detects the class file changes one after another rather than in the same loop:
|
liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/server/DevMojo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
…iggered from build file change Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
…asses Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
…ling dev mode IT Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
…file for generate features Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Signed-off-by: Kathryn Kodama <kathryn.s.kodama@gmail.com>
Fixes #1375
Enabled generateFeatures for MultiModuleUpdatePomsTest.
General dev mode improvements:
On build file change, dependency equals check was always indicating that dependencies had changed even when the two lists were the same. Added the
dependencyListEquals(...)
anddependencyEquals(...)
methods to compare dependencies. Dependencies are considered "equal" if they have the same groupId, artifactId, version, type and scope.When checking if compilation dependencies have changed, include dependencies with scope "provided" as they are also used to build the project and should be considered compile dependencies. See https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope
Feature generation flow:
If a build file is modified and compilation dependencies have changed, call generateFeatures if:
EDIT: updated to only call incrementGenerateFeatures if there are class files to generate for
multi module project: (1) main module's compile dependencies were modified and source directory exists OR (2) module's compile dependencies were modified and there are dependent modulessingle module project: source directory exists