Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate features and dev mode, modifying pom.xml in multi module project errors #1375

Closed
kathrynkodama opened this issue Jan 17, 2022 · 2 comments · Fixed by #1409
Closed
Assignees
Labels
bug devMode generateFeatures Issues that target the generateFeatures branch

Comments

@kathrynkodama
Copy link
Contributor

kathrynkodama commented Jan 17, 2022

To reproduce
See the logic in MultiModuleUpdatePomsTests

With feature generation enabled, after war module's pom.xml is modified

generate features runs twice and on the second run throws an error:

[INFO] [INFO] guide-maven-multimodules-war source compilation was successful.
[INFO] [INFO] guide-maven-multimodules-war tests compilation was successful.
[INFO] [INFO] guide-maven-multimodules-ear tests compilation was successful.
[INFO] [INFO] Generating feature list from incremental changes...
[INFO] [INFO] Running liberty:generate-features
[INFO] [INFO] Parsing the server file /tmp/temp7486163829553659348/ear/src/main/liberty/config/server.xml for features and includes.
[INFO] [INFO] [AUDIT   ] CWWKT0017I: Web application removed (default_host): http://fv-az50-99.scfqo42wrlxuxg5qb0ygs2t2if.cx.internal.cloudapp.net:9080/converter/
[INFO] [INFO] [AUDIT   ] CWWKZ0009I: The application guide-maven-multimodules-ear has stopped successfully.
[INFO] [INFO] [AUDIT   ] CWWKT0016I: Web application available (default_host): http://fv-az50-99.scfqo42wrlxuxg5qb0ygs2t2if.cx.internal.cloudapp.net:9080/converter/
[INFO] [INFO] [AUDIT   ] CWWKZ0003I: The application guide-maven-multimodules-ear updated in 0.071 seconds.
[INFO] [INFO] Parsing the server file /tmp/temp7486163829553659348/ear/src/main/liberty/config/server.xml for features and includes.
[INFO] [INFO] No additional features were generated.
[INFO] [INFO] Running liberty:generate-features
[INFO] [INFO] Parsing the server file /tmp/temp7486163829553659348/ear/src/main/liberty/config/server.xml for features and includes.
Error: [ERROR] Failed to generate a working set of features. Error scanning the application for Liberty features: java.lang.NullPointerException.
[INFO] To disable the automatic generation of features, type 'g' and press Enter.

Expected Behaviour
Feature generation only runs once, no additional features are generated.

@kathrynkodama
Copy link
Contributor Author

May be the same issue described: #1321 (comment)
but requires further investigation.

@kathrynkodama kathrynkodama self-assigned this Jan 25, 2022
@kathrynkodama
Copy link
Contributor Author

NPE should be fixed with OpenLiberty/ci.common#343 but still need to investigate why generate features is running twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug devMode generateFeatures Issues that target the generateFeatures branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant