MoorDyn v2 C-bindings interface #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables to pass through C interface, 3) updated compilation instructions
This routine allows for passing an input file as one long string with C_NULL_CHAR deliations between lines of the input file Set interface for InitFileInfo.
…nd fix broken test Also reorder part of the InitFileInfo_FromStringArray routine
…gainst the fortran string array method
…need to do mesh mapping
…t outputs still not matching
- Previously MD_Init incorrectly set mesh reference positions to the displaced positions of any coupled connections. - This fix brings it inline with other versions, where reference position is set to relative location of connection point as given in input file, and initial offset is applied as a TranslationDisp.
Grabbing Matt's and ANdy's fix to MoorDyn.f90
Includes - adjust time tracking for passing to MD_UpdateStates - add VersionInfo to the DLL
… GCC with the REWIND setup)
- modify format to follow standard OF output file (6 header lines) - change text from 'alpha' designation
- could not match values from full simulation due to lack of output precision
- note: three cases are ommitted because they are excessively slow in double precision release
andrew-platt
reviewed
Dec 8, 2022
rafmudaf
reviewed
Dec 9, 2022
|
@andrew-platt I looked through the CMake configuration and the testing infrastructure, and it all generally looks good to me. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to be merged until MD v2 PR (#750) is completed
Feature or improvement description
New python/C wrapper for MoorDyn module. Contains a "driver" script that calls individual MD subroutines that should go in r-test, a python library interface, and the fortran c-bound interface that will go with the MD source code.
Related issue, if one exists
Tied to MC v2 PR (#750 )
Impacted areas of the software
MoorDyn
Additional supporting information
Test results, if applicable
This code has been verified against MD v1 using the OC4 Semi test case.
To Do List