Remove references to ADAMS coupling #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjonkman and @andrew-platt, as noted in the PR description, I did not remove the ElastoDyn outputs related to ADAMS since multiple regression tests use these outputs (though they are zero for all). Removing them would require updating the baselines for these regression tests. I can remove them if that would be preferable. |
|
I'll remove the Adams output channels with the AD14 deprecation PR (there are some regression test updates with it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Changes are complete and all regression tests pass.
Feature or improvement description
This pull request removes references to ADAMS coupling in the code. References to ADAMS remain in AeroSubs.f90, which will be deprecated with AeroDyn14. Some outputs related to ADAMS coupling remain as well, since multiple regression tests reference these outputs, and removing them would require updating these baselines.
Impacted areas of the software
-ElastoDyn
-IceFloe