Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/950 inject broken filter for the attck matrix #1082

Merged

Conversation

Christian-DONGMO
Copy link
Contributor

@Christian-DONGMO Christian-DONGMO commented Jun 13, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

We fill the need to replace the previous number of sub techniques into the att&ck matrix by the number of injectors contract
…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
@RomuDeuxfois
Copy link
Member

The build is broken

…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.34%. Comparing base (47afe03) to head (24c0959).

Files Patch % Lines
...as/rest/injector_contract/InjectorContractApi.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1082      +/-   ##
============================================
- Coverage     26.38%   26.34%   -0.04%     
+ Complexity     1063     1059       -4     
============================================
  Files           474      474              
  Lines         11325    11319       -6     
  Branches        579      579              
============================================
- Hits           2988     2982       -6     
  Misses         8253     8253              
  Partials         84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomuDeuxfois RomuDeuxfois added the filigran team use to identify PR from the Filigran team label Jun 18, 2024
…into issue/950-inject-broken-filter-for-the-attck-matrix
…into issue/950-inject-broken-filter-for-the-attck-matrix
@Christian-DONGMO Christian-DONGMO merged commit 5db0f5d into master Jun 24, 2024
6 checks passed
@Christian-DONGMO Christian-DONGMO deleted the issue/950-inject-broken-filter-for-the-attck-matrix branch June 24, 2024 14:21
johanah29 pushed a commit that referenced this pull request Jun 27, 2024
[Backend] 950 - inject broken filter for the attck matrix
Resolved broken filter for the att&ck matrix
We fill the need to replace the previous number of sub techniques into the att&ck matrix by the number of injectors contract
johanah29 pushed a commit that referenced this pull request Jul 15, 2024
[Backend] 950 - inject broken filter for the attck matrix
Resolved broken filter for the att&ck matrix
We fill the need to replace the previous number of sub techniques into the att&ck matrix by the number of injectors contract
johanah29 pushed a commit that referenced this pull request Jul 16, 2024
[Backend] 950 - inject broken filter for the attck matrix
Resolved broken filter for the att&ck matrix
We fill the need to replace the previous number of sub techniques into the att&ck matrix by the number of injectors contract
johanah29 pushed a commit that referenced this pull request Jul 16, 2024
[Backend] 950 - inject broken filter for the attck matrix
Resolved broken filter for the att&ck matrix
We fill the need to replace the previous number of sub techniques into the att&ck matrix by the number of injectors contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject: Broken filter for the ATT&CK matrix
3 participants