Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject: Broken filter for the ATT&CK matrix #950

Closed
marckto-filigran opened this issue May 23, 2024 · 3 comments · Fixed by #1082
Closed

Inject: Broken filter for the ATT&CK matrix #950

marckto-filigran opened this issue May 23, 2024 · 3 comments · Fixed by #1082
Assignees
Labels
bug use for describing something not working as expected solved The issue has been solved
Milestone

Comments

@marckto-filigran
Copy link

Description

From the ATT&CK Matrix, when you add a filter, the number of result has nothing to do with what is displayed.

Environment

  1. Other environment details: https://demo.obas.filigran.io/

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Create a scenario
  2. Add an inject, click on ATT&CK
  3. Select one technique for example T1583 > 8
    image

Expected Output

8 results

Actual Output

no result
image

Additional information

Another example with T1559 (3)
6 results
image

@marckto-filigran marckto-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels May 23, 2024
@Kedae Kedae added this to the Bugs backlog milestone May 23, 2024
@jborozco jborozco removed the needs triage use to identify issue needing triage from Filigran Product team label May 24, 2024
@RomuDeuxfois
Copy link
Member

The number in parentheses is not the number of results but the number of existing sub-techniques
There is a need to reflect on this information to be displayed which is not clear to the user @jborozco

@jborozco
Copy link

jborozco commented Jun 5, 2024

@RomuDeuxfois

Since we don't have sub-techniques visible yet, we can show here the number of available injects to be clearer.

To avoid unecessary clicks it would be great to deactivate all attack patterns without injects for the MITRE filter

I will create a feature ticket about being able to select sub techniques in the MITRE filter so we can cover this case too

@jborozco
Copy link

jborozco commented Jun 5, 2024

Feature request for MITRE filter improvement #1053

@Christian-DONGMO Christian-DONGMO self-assigned this Jun 11, 2024
@Christian-DONGMO Christian-DONGMO linked a pull request Jun 13, 2024 that will close this issue
5 tasks
@Christian-DONGMO Christian-DONGMO added the solved The issue has been solved label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved The issue has been solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants