Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Ada] Incorrect client Ada code generated #7596

Closed
wants to merge 2 commits into from

Conversation

stcarrez
Copy link
Contributor

@stcarrez stcarrez commented Oct 4, 2020

  • Fix the identification of path parameters
  • Fix the model and client to support FreeFormObject

To fix #7594

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

- Fix the identification of path parameters
- Fix the model and client to support FreeFormObject
@codymikol
Copy link
Contributor

You might want to do git commit --amend --no-edit && git push -f The circle CI build timed out for me as well and just needed to be rerun

@wing328
Copy link
Member

wing328 commented Oct 7, 2020

Pushed 765c7bf to fix the CI failure. Let's see how that goes.

@wing328 wing328 changed the title Fix #7594: [BUG][Ada] Incorrect client Ada code generated [BUG][Ada] Incorrect client Ada code generated Oct 14, 2020
@wing328
Copy link
Member

wing328 commented Oct 14, 2020

@codymikol FYI. Another way is to close and reopen the PR to trigger all the CI jobs.

@wing328 wing328 closed this Oct 14, 2020
@wing328 wing328 reopened this Oct 14, 2020
@wing328
Copy link
Member

wing328 commented Oct 14, 2020

I know how to fix the CI failures. Will do it later this week.

@wing328
Copy link
Member

wing328 commented Oct 15, 2020

@stcarrez Not sure why but I couldn't fix the issue in your branch. I've created #7719 instead.

@stcarrez
Copy link
Contributor Author

@wing328, thanks for the integration! I'm closing this pull request since you integrated it.

@stcarrez stcarrez closed this Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Ada] Incorrect client Ada code generated
3 participants