Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Ada] Incorrect client Ada code generated #7594

Closed
4 of 6 tasks
stcarrez opened this issue Oct 4, 2020 · 0 comments · Fixed by #7719
Closed
4 of 6 tasks

[BUG][Ada] Incorrect client Ada code generated #7594

stcarrez opened this issue Oct 4, 2020 · 0 comments · Fixed by #7719

Comments

@stcarrez
Copy link
Contributor

stcarrez commented Oct 4, 2020

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

The Ada client generator generates incorrect code:

  • when a FreeFormObject is used,
  • when several path parameters are used
openapi-generator version

5.0.0-SNAPSHOT.

OpenAPI declaration file content or url

A partial example of URL with two path parameters:

paths:
  '/converter/{format}/{target}':
    post:
      tags:
        - converter
      summary: Convert a text from one format to another
      description: ''
      operationId: convert
      parameters:
        - name: format
          in: path
          description: The source Wiki format
          required: true
          schema:
            type: string
            enum:
              - html
              - markdown
              - dotclear
              - creole
              - mediawiki
        - name: target
          in: path
          description: The target Wiki format
          required: true
          schema:
            type: string
Generation Details
  • The code generator generates the same index number for both path parameters (we can access only the first path parameter!!!)
  • The FreeFormObject generates code that does not compile.
Steps to reproduce

I'm using the following command:

openapi-generator generate --generator-name ada -i file.yaml --additional-properties projectName=todos --model-package Todos -o .
Related issues/PRs
Suggest a fix

I'll submit a pull to fix the above :-)

@stcarrez stcarrez changed the title [BUG] Incorrect client Ada code generated [BUG][Ada] Incorrect client Ada code generated Oct 4, 2020
stcarrez added a commit to stcarrez/openapi-generator that referenced this issue Oct 4, 2020
- Fix the identification of path parameters
- Fix the model and client to support FreeFormObject
wing328 added a commit that referenced this issue Oct 15, 2020
* Fix #7594: [BUG][Ada] Incorrect client Ada code generated

- Fix the identification of path parameters
- Fix the model and client to support FreeFormObject

* update doc

* fix errors, update samples

Co-authored-by: Stephane Carrez <Stephane.Carrez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant