-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Golang] Allow retrieving the underlying configuration for APIClient #3976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 could come handy in some situations.
Oh BTW could you do a similar change to the |
We should add a warning that modifying the configuration while live can cause data races and potentially unwanted behavior. It was intentionally protected. |
@bkabrda I tried to run |
@arvindth please commit those and we'll review. |
@wing328 could you reopen this PR? I don't think the new commits on the branch will show up otherwise. |
After the rebase forward, |
Tests passed via https://circleci.com/gh/OpenAPITools/openapi-generator/9674 |
I'll file another PR for go-experimental generator |
@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
1 similar comment
@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master
,4.1.x
,5.0.x
. Default:master
.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
*http.Client
Accessor #3412cc @antihax @bvwells @grokify @kemokemo @bkabrda since this is a Go related change.