Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Golang] Allow retrieving the underlying configuration for APIClient #3976

Merged
merged 3 commits into from
Oct 21, 2019
Merged

[Golang] Allow retrieving the underlying configuration for APIClient #3976

merged 3 commits into from
Oct 21, 2019

Conversation

arvindth
Copy link
Contributor

@arvindth arvindth commented Sep 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

cc @antihax @bvwells @grokify @kemokemo @bkabrda since this is a Go related change.

@arvindth arvindth changed the title Allow retrieving the underlying configuration for APIClient [Golang] Allow retrieving the underlying configuration for APIClient Sep 28, 2019
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 could come handy in some situations.

@bkabrda
Copy link
Contributor

bkabrda commented Sep 30, 2019

Oh BTW could you do a similar change to the go-experimental templates, @arvindth.

@bkabrda
Copy link
Contributor

bkabrda commented Oct 2, 2019

@wing328 I think this PR was closed by mistake, IMO the #3996 PR that was merged was supposed to resolve a different issue.

@antihax
Copy link
Contributor

antihax commented Oct 2, 2019

We should add a warning that modifying the configuration while live can cause data races and potentially unwanted behavior. It was intentionally protected.

@arvindth
Copy link
Contributor Author

arvindth commented Oct 4, 2019

@bkabrda I tried to run ./bin/go-experimental-petstore.sh but I see a lot of changes unrelated to mine. Any advice on what I can do?

@wing328
Copy link
Member

wing328 commented Oct 4, 2019

@arvindth please commit those and we'll review.

@arvindth
Copy link
Contributor Author

arvindth commented Oct 4, 2019

@wing328 could you reopen this PR? I don't think the new commits on the branch will show up otherwise.

@wing328 wing328 reopened this Oct 4, 2019
@arvindth
Copy link
Contributor Author

arvindth commented Oct 4, 2019

After the rebase forward, ./bin/go-experimental-petstore.sh showed no changes.

@wing328
Copy link
Member

wing328 commented Oct 21, 2019

@wing328 wing328 merged commit 893f16a into OpenAPITools:master Oct 21, 2019
@wing328
Copy link
Member

wing328 commented Oct 21, 2019

I'll file another PR for go-experimental generator

@arvindth arvindth deleted the ath-expose-config branch October 24, 2019 04:26
@wing328 wing328 added this to the 4.2.0 milestone Oct 30, 2019
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

1 similar comment
@wing328
Copy link
Member

wing328 commented Oct 31, 2019

@arvindth thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants