Clean-up - Unnecessary trailing underscores in Python Flask, AIOHttp, BluePlanet #16249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the files generated for the python-flask language contain unnecessary trailing underscores at the end of their name.
I looked for a good reason to do so, but couldn't find one, these happened in:
I have renamed the files to have them named base_model.py (instead of base_model_.py) and security_controller.py (instead of security_controller_.py). While doing so, I had to touch the
AbstractPythonConnexionServerCodegen
which ended up touching the AIOHttp and BluePlanet Python generators, which I also fixed.Adding @krjakbrjak and @spacether as Python committee member for review and feedback
Merging into master as it is a minor change.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
In case you are adding a new generator, run the following additional script :master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)