Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up - Unnecessary trailing underscores in Python Flask, AIOHttp, BluePlanet #16249

Merged

Conversation

yilmi
Copy link
Contributor

@yilmi yilmi commented Aug 3, 2023

Description

Some of the files generated for the python-flask language contain unnecessary trailing underscores at the end of their name.

I looked for a good reason to do so, but couldn't find one, these happened in:

I have renamed the files to have them named base_model.py (instead of base_model_.py) and security_controller.py (instead of security_controller_.py). While doing so, I had to touch the AbstractPythonConnexionServerCodegen which ended up touching the AIOHttp and BluePlanet Python generators, which I also fixed.

Adding @krjakbrjak and @spacether as Python committee member for review and feedback

Merging into master as it is a minor change.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@yilmi yilmi force-pushed the flask_security_controller_name_fix branch from 606a848 to f46564a Compare August 3, 2023 13:17
@yilmi yilmi marked this pull request as ready for review August 3, 2023 13:17
@yilmi yilmi changed the title Clean-up - Unnecessary trailing underscores in Python Flask, AIOHttp, security_controller_.py and base_model_.py Clean-up - Unnecessary trailing underscores in Python Flask, AIOHttp, BluePlanet Aug 3, 2023
@wing328
Copy link
Member

wing328 commented Aug 14, 2023

I didn't know the reason either. Let's go with your change and see how that goes.

@wing328 wing328 merged commit 931197a into OpenAPITools:master Aug 14, 2023
@yilmi yilmi deleted the flask_security_controller_name_fix branch August 15, 2023 19:46
@wing328 wing328 added this to the 7.0.0 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants