-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python AIOHTTP server generator #1470
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@Jyhess thanks for the PR. Are you free on the coming week to have a quick chat about this PR? I'm available via https://gitter.im (ID: wing328) or Google Hangout (you can find the email address in my profile page) |
Hi William,
We can have a chat on gitter this week.
I'm available from 10 am french timezone, 5 pm for you I guess.
FYI, I updated my PR with some more fixes.
BR,
Julien
Le sam. 24 nov. 2018 à 10:18, William Cheng <notifications@github.com> a
écrit :
… @Jyhess <https://github.com/Jyhess> thanks for the PR. Are you free on
the coming week to have a quick chat about this PR?
I'm available via https://gitter.im (ID: wing328) or Google Hangout (you
can find the email address in my profile page)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1470 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYB-oI45etkTSewCgRt5lko7iWmiD2Ppks5uyQ7rgaJpZM4YmPJN>
.
|
8e17002
to
fe785d5
Compare
...r/src/main/java/org/openapitools/codegen/languages/PythonAbstractConnexionServerCodegen.java
Outdated
Show resolved
Hide resolved
@Jyhess currently, we test the python clients in Travis by adding the folders to pom.xml: https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml#L1039 If it's not a lot of work, I suggest we do the same for Python AIOHTTP Petstore server samples by adding a pom.xml under |
Tests for generated server cannot succeed until this PR on connexion is not released. Moreover, there is some other issues in generated tests for the moment:
I will add travis files and find a way to deactivate or fix failing tests. |
84f13ba
to
2dd48a5
Compare
@wing328 I fixed tests. I also added and fixed tests for python-flask generator. |
2dd48a5
to
33e322e
Compare
33e322e
to
2671b5b
Compare
I'll review again later today or tomorrow and merge it into master if no further feedback |
f89d07e
to
6549dc8
Compare
OK, I fixed some tests and normalized flask folders. |
* Astract factory for generators based on connexion * Add aiohttp server generator * Fix flask tests * Normalize python-flask folder names
@wing328 @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus
Following issue 1322, I started to write a generator for aiohttp server.
It's a work in progress, and I would like early review and help to fix some remaining issues.
Note:
And here is some questions:
In preprocessOpenAPI function, I set body name to "body" by default. I would like set it to type name (pet or user is better, but didn't figure how to get easily this information. Do you know how I can find this information ?
In model.mustach, I would like to generate imports for other generated class, like
Do you know how I can do that ? There is the same issue with Flask generator.
In test controllers, examples are not generated. Any clue on that ?
Do you know why side files, like git_push.sh, or setup.py are generated? I'm not sure they should be part of a code generator.