2132 better formulas #2157
Merged
2132 better formulas #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yuri05 Just changed for one Rate. Can you check to make sure this is what you mean? |
msevestre
commented
Apr 1, 2022
| @@ -3922,7 +3922,7 @@ INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','ActiveEffluxSpeci | |||
| INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','ActiveEffluxSpecificWithTransporterInTarget_MM','TM * kcat * K_water_src * C_src / (Km + K_water_src * C_src)','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','ActiveInfluxSpecificWithTransporterInSource_Hill','TM * kcat * (K_water_src * max(C_src;0))^alpha / (Km^alpha + (K_water_src * max(C_src;0))^alpha)','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','ActiveInfluxSpecificWithTransporterInSource_MM','TM * kcat * K_water_src * C_src / (Km + K_water_src * C_src)','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','BrainPgPToPlasma_Hill','Min(CP * f_int * V * kcat * (fu * max(C_pls;0))^alpha / ( Km^alpha + (fu * max(C_pls;0))^alpha) ; P_endothelial * SA * fu * C_pls) + CP * f_int * V * kcat * (K_water_int * max(C_int;0))^alpha / (Km^alpha + (K_water_int * max(C_int;0))^alpha)','Amount per time'); | |||
| INSERT INTO tab_calculation_method_rates VALUES('LinksCommon','BrainPgPToPlasma_Hill','Min(TM * kcat * (fu * max(C_pls;0))^alpha / ( Km^alpha + (fu * max(C_pls;0))^alpha) ; P_endothelial * SA * fu * C_pls) + TM * kcat * (K_water_int * max(C_int;0))^alpha / (Km^alpha + (K_water_int * max(C_int;0))^alpha)','Amount per time'); | |||
There was a problem hiding this comment.
TM for Transporter Amount. This is what we use in another transports
| @@ -85780,7 +85780,7 @@ INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','ActiveInfluxSpecifi | |||
| INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','ActiveInfluxSpecificWithTransporterInSource_MM',366,'DRUG','TM',1); | |||
| INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','BrainPgPToPlasma_Hill',341,'DRUG','C_int',0); | |||
| INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','BrainPgPToPlasma_Hill',351,'DRUG','C_pls',0); | |||
| INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','BrainPgPToPlasma_Hill',366,'DRUG','CP',0); | |||
| INSERT INTO tab_rate_generic_molecules VALUES('LinksCommon','BrainPgPToPlasma_Hill',366,'DRUG','TM',1); | |||
| @@ -403,7 +403,7 @@ public static class Error | |||
| public static string DistributionUnknown(string distribution) => $"Distribution '{distribution}' is unknown."; | |||
| public const string NameIsRequired = "Name is required."; | |||
| public const string MoleculeIsRequired = "Molecule is required."; | |||
| public const string CategoryIsRequired = "Category is required."; | |||
| public static readonly string CategoryIsRequired = $"{UI.ExpressionProfileCategory} is required."; | |||
There was a problem hiding this comment.
something else to get a better results
|
@Yuri05 All right. Should be all there. I am going to run the batch files to make sure there is no obvious corruption |
Yuri05
reviewed
Apr 6, 2022
| INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4713,'DRUG','C_pls_prp',1); | ||
| INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4718,'DRUG','C_pls_prc',1); | ||
| INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4723,'DRUG','C_end_prp',1); | ||
| INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4728,'DRUG','C_end_prc',1); |
There was a problem hiding this comment.
Those entries are not required anymore and should be deleted
INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4708,'DRUG','C_cell_prc',1);
INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4713,'DRUG','C_pls_prp',1);
INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4718,'DRUG','C_pls_prc',1);
INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4723,'DRUG','C_end_prp',1);
INSERT INTO tab_rate_generic_molecules VALUES('Observer_PKSim_2Poren','OBS_WholeOrgan_liv',4728,'DRUG','C_end_prc',1);
There was a problem hiding this comment.
hum..it's not there lot
|
@msevestre ok, apart from https://github.com/Open-Systems-Pharmacology/PK-Sim/pull/2157/files#r843794150 looks good for me. When this is fixed we can merge and then I would run the batch comparison before we fix the pgp issue |
|
ok merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.