2113 property molecule psv #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
commented
Mar 15, 2022
| INSERT INTO tab_rate_generic_parameters(calculation_method,formula_rate,path_id,parameter_name,alias) VALUES('ExpressionParameters','PARAM_f_exp_bc_membrane',139,'Fraction expressed in blood cells','f_exp_bc_cell'); | ||
| DELETE FROM tab_rate_generic_parameters WHERE calculation_method='ExpressionParameters' AND formula_rate='PARAM_f_exp_bc_membrane' AND path_id=240 AND parameter_name='Fraction expressed in blood cells'; | ||
| INSERT INTO tab_rate_generic_parameters(calculation_method,formula_rate,path_id,parameter_name,alias) VALUES('ExpressionParameters','PARAM_f_exp_vasc_tissue_side',139,'Fraction expressed in endosomes','f_exp_vasend_endosomes'); | ||
| INSERT INTO tab_rate_generic_parameters(calculation_method,formula_rate,path_id,parameter_name,alias) VALUES('ExpressionParameters','PARAM_f_exp_vasc_tissue_side',139,'Fraction expressed on plasma-side membrane of vascular endothelium','f_exp_vasend_plasma'); |
There was a problem hiding this comment.
.. instead of MOLECULE
| propertyParameters.Each(x => | ||
| { | ||
| var parameterPath = _entityPathResolver.ObjectPathFor(x); | ||
| _psv[parameterPath].ShouldBeNull(); |
There was a problem hiding this comment.
do not add entries for property parameters (they should be excluded from psv)
| @@ -89,13 +90,16 @@ private void setParameter(IParameter parameter, bool isSmallMolecule) | |||
| if (parameter.HasAncestorNamed(CoreConstants.Compartment.ENDOSOME) && isSmallMolecule) | |||
| return; | |||
|
|
|||
| var parameterStartValue = getOrCreateStartValueFor(parameter); | |||
| //We do not generate value for this parameter by default. Exit | |||
| var parameterStartValue = getStartValueFor(parameter); | |||
There was a problem hiding this comment.
We were adding entries for formula that are the same everywhere. Not generated by default in Core and it should not be added here either
Yuri05
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.