Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After export from PK-Sim, some "Property" parameters are in the PSV-BB #2113

Closed
PavelBal opened this issue Mar 4, 2022 · 9 comments
Closed
Assignees

Comments

@PavelBal
Copy link
Member

PavelBal commented Mar 4, 2022

After exporting a PK-Sim model with expressed proteins, following parameters that are "Property" are created in the PSV-BB:

  • Fraction expressed in blood cells membrane
  • Fraction expressed on tissue-side membrane of vascular endothelium

What for? @msevestre It is a bug, don't you think?

@msevestre
Copy link
Member

What's the logic again? We only create value in PSV for what parameters?

@PavelBal
Copy link
Member Author

PavelBal commented Mar 4, 2022

Global and local, if those are not defined by a formula. I actually know why this is explicitely added - in the molecules-BB the value of Fraction expressed in blood cells membrane is NaN and nans are now filtered out from PSV-BB.

The new expression logic makes it very hard to extend spatial structure - the relevent parameters

Fraction expressed interstitial
Fraction expressed intracellular
Relative expression

are not extended to new compartments. I understand WHY it has been implemented like this but I think we need another solution. We really need a way to define MoleculeProperties on organ level (i.e. not only for physical containers, but also for logical). In this case, the above mentioned parameters could be defined as "Organ"-properties. Let's maybe have a chat about it some time.

@StephanSchaller
Copy link
Member

StephanSchaller commented Mar 6, 2022

Could be solved by tags / container criteria as in #2112# ?

@msevestre
Copy link
Member

Let's discuss this tomorrow during the meeting

@msevestre
Copy link
Member

This will be resolved with usage of ContainerCriteria for Parameters in Molecule

@msevestre msevestre self-assigned this Mar 15, 2022
@msevestre
Copy link
Member

I don't understand this bug here. What is the expected behavior? Property parameter should not be added to the PSV correct?

@msevestre
Copy link
Member

Fraction expressed in blood cells membrane is NaN just because it's a formula and the tag are defined with MOLECULE instead of ..

@msevestre
Copy link
Member

oh I see. They should not be created because they are property

@RobinM92
Copy link

RobinM92 commented Apr 9, 2022

Hello,
I was wondering if this issue is the cause of unwanted behavior of relative expression when sending a simulation from pksim to mobi. E.g. in Open-Systems-Pharmacology/Forum#1151 I sent asimulation using relative expression of EGFR to MoBi, and all the relative expression values are attributed to intracellular expression in the tissues (probably due how it is coded connected to the interstitial expression). For now, the only work-around I have found is adding all relative expression values per tissue (in ISF, plasma and blood cells) manually, which is extremely cumbersome and errorprone. Of course this is relevant as we use rel. expression in the turnover reactions of receptors per tissue, if not they all converge to the same concentration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants