-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1933 Add urine compartment #2049
Conversation
@@ -74327,6 +74334,7 @@ INSERT INTO tab_parameters VALUES('Sum of active process rates lumen to mucosa', | |||
INSERT INTO tab_parameters VALUES('Target eGFR','Target eGFR','Target eGFR value','Flow per body surface area',NULL); | |||
INSERT INTO tab_parameters VALUES('eGFR','eGFR','Estimated GFR is the GFR normalized to body surface area (BSA). The eGFR is used clinically to determine staging of chronic kidney disease.','Flow per body surface area',NULL); | |||
INSERT INTO tab_parameters VALUES('Disease factor','Disease factor','Used for scaling reference concentration based on the selected disease state.','Dimensionless',NULL); | |||
INSERT INTO tab_parameters VALUES('Urine compartment emptying enabled','Urine compartment emptying enabled','TODO: Enable urine compartment emptying','Dimensionless',NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yuri05 Description required here
@@ -54944,6 +54946,8 @@ INSERT INTO tab_container_parameter_rates VALUES(5954,'DISEASE_STATE','CKD','Tar | |||
INSERT INTO tab_container_parameter_rates VALUES(157,'ORGAN','Kidney','eGFR','GFR_Calculation','PARAM_eGFR',0.0,1,NULL,1,NULL); | |||
INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Disease factor','DiseaseStates','One_Rate',0.0,1,NULL,1,NULL); | |||
INSERT INTO tab_container_parameter_rates VALUES(5941,'GENERAL','TRANSPORTER','Disease factor','DiseaseStates','One_Rate',0.0,1,NULL,1,NULL); | |||
INSERT INTO tab_container_parameter_rates VALUES(5955,'EVENTGROUP','Urine compartment emptying','Urine compartment emptying enabled','Events','One_Rate',0.0,1,1.0,1,NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this parameter Urine compartment emptying enabled
?
Because the users want to be able to activate/deactivate the event in a simulation without reconfiguring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if it should not be "Uring emptying enabled"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since urine is a compartment already. Why do we have the name compartment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to Gallbladder emptying enabled we do not say Gallbladder compartment xx
Going to rename for consistency sake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I think the event and the parameter should be called "Bladder emptying" / "Bladder emptying enabled"
(or "Urinary bladder emptying" / "Urinary bladder emptying enabled").
Maybe somebody with medical background (@sfrechen ?) can comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me..
Urinary bladder sounds more physiological than urine compartment
Ok let's agree on nomenclature before I continue |
going to go with Urinary bladder and rename accordingly |
No description provided.