Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1933 Add urine compartment #2049

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

msevestre
Copy link
Member

No description provided.

@msevestre msevestre requested a review from Yuri05 January 16, 2022 15:12
@msevestre msevestre marked this pull request as ready for review January 16, 2022 15:12
@msevestre msevestre changed the title DRAFT: WIP #1933 Add urine compartment Fixes #1933 Add urine compartment Jan 16, 2022
@@ -74327,6 +74334,7 @@ INSERT INTO tab_parameters VALUES('Sum of active process rates lumen to mucosa',
INSERT INTO tab_parameters VALUES('Target eGFR','Target eGFR','Target eGFR value','Flow per body surface area',NULL);
INSERT INTO tab_parameters VALUES('eGFR','eGFR','Estimated GFR is the GFR normalized to body surface area (BSA). The eGFR is used clinically to determine staging of chronic kidney disease.','Flow per body surface area',NULL);
INSERT INTO tab_parameters VALUES('Disease factor','Disease factor','Used for scaling reference concentration based on the selected disease state.','Dimensionless',NULL);
INSERT INTO tab_parameters VALUES('Urine compartment emptying enabled','Urine compartment emptying enabled','TODO: Enable urine compartment emptying','Dimensionless',NULL);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 Description required here

@@ -54944,6 +54946,8 @@ INSERT INTO tab_container_parameter_rates VALUES(5954,'DISEASE_STATE','CKD','Tar
INSERT INTO tab_container_parameter_rates VALUES(157,'ORGAN','Kidney','eGFR','GFR_Calculation','PARAM_eGFR',0.0,1,NULL,1,NULL);
INSERT INTO tab_container_parameter_rates VALUES(5015,'GENERAL','PROTEIN','Disease factor','DiseaseStates','One_Rate',0.0,1,NULL,1,NULL);
INSERT INTO tab_container_parameter_rates VALUES(5941,'GENERAL','TRANSPORTER','Disease factor','DiseaseStates','One_Rate',0.0,1,NULL,1,NULL);
INSERT INTO tab_container_parameter_rates VALUES(5955,'EVENTGROUP','Urine compartment emptying','Urine compartment emptying enabled','Events','One_Rate',0.0,1,1.0,1,NULL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this parameter Urine compartment emptying enabled?
Because the users want to be able to activate/deactivate the event in a simulation without reconfiguring?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if it should not be "Uring emptying enabled"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since urine is a compartment already. Why do we have the name compartment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to Gallbladder emptying enabled we do not say Gallbladder compartment xx
Going to rename for consistency sake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think the event and the parameter should be called "Bladder emptying" / "Bladder emptying enabled"
(or "Urinary bladder emptying" / "Urinary bladder emptying enabled").
Maybe somebody with medical background (@sfrechen ?) can comment on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me..
Urinary bladder sounds more physiological than urine compartment

@msevestre
Copy link
Member Author

Ok let's agree on nomenclature before I continue
Suggetion of @Yuri05 makes sense to me

@msevestre
Copy link
Member Author

going to go with Urinary bladder and rename accordingly
Then we can always rename later. I need to merge the DB to keep workoing

@msevestre msevestre merged commit 69f4c8e into develop Jan 18, 2022
@msevestre msevestre deleted the 1933-add-urine-compartment-emptying branch January 18, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants