Issue #350: Fix unit tests that failed on Windows because of differen… #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce in config paths.
soxofaan
reviewed
Dec 15, 2022
soxofaan
deleted the
issue350-unit-test-for-configuration-fail-on-windows
branch
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 350: Fix unit tests that failed on Windows because of difference in config paths.
This fixes the three test mentioned in issue #350
On windows we needed to set another environment variable APPDATA in two of the tests, and use the path separator from os.sep in another test.
Together with issue the PR for issue #198, which is PR #351, it should make all tests pass on Windows.