Issue198 permission issues with privatejsonfile on windows #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_config.py:163: AttributeError AttributeError: 'function' object has no attribute 'st_mode'
soxofaan
reviewed
Dec 15, 2022
soxofaan
reviewed
Dec 15, 2022
…ut in extra_requires if you want it on another platform
|
looks good can you also add a CHANGELOG.md entry? |
CHANGELOG.md updated. |
|
merged in 1de20ba |
This was referenced Jan 4, 2023
JohanKJSchreurs
deleted the
issue198-permission-issues-with-privatejsonfile-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #198
This uses the oschmod library to be able to use similar file permission on Windows.
For now it only installs and uses it on WIndows systems.
Possibly this can be simplified a bit, making it more uniform across Windows, Linux and Mac by using oschmod for all platforms.
But I propose to test this first and see if there are any issues.