-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imagecollection vs datacube #108
Comments
FYI: in 6fc4cee I already sort of deprecated |
However, what we could also put up for discussion is renaming the class To me it sounds indeed better because the thing acts more like a homogeneous cube than a collection of images. However it would require quite a large "diff" to address this, and I'm not sure if it is worth that trouble. A normal user should not use the class directly to create an instance anyway (but On the other hand, when using the documentation of the python client, the user is still confronted with this what do you think @jdries ? |
This all makes a lot of sense, especially now that the API is supposed to be stable. |
the just merged PR #126 introduced new |
From what I see in examples, the Python client currently uses "imagecollection" to create processing instructions. Wouldn't it be more aligned with what we do to call this datacube? So to replace
con.imagecollection("s2", ...)
with something likecon.datacube("s2", ...)
? I got to think about this when updating https://openeo.org/documentation/draft/developers/clients/library-guidelines.htmlThe text was updated successfully, but these errors were encountered: