Skip to content

Commit

Permalink
fixup! fixup! EP-3251 #116 #108 #124 added todo notes
Browse files Browse the repository at this point in the history
  • Loading branch information
soxofaan committed Mar 3, 2020
1 parent 438e50d commit 6a3c754
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions openeo/rest/datacube.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import copy
import datetime
import logging
import pathlib
import typing
from typing import List, Dict, Union, Tuple
Expand All @@ -19,6 +20,10 @@
# Note: the `hasattr` check is necessary for Python versions before 3.5.2.
from openeo.rest.connection import Connection


log = logging.getLogger(__name__)


# TODO #108 this file is still full of "ImageCollection" references (type hints, docs, isinstance checks, ...)

class DataCube(ImageCollection):
Expand Down Expand Up @@ -310,6 +315,7 @@ def __lt__(self, other: Union[ImageCollection, Union[int, float]]):
def _create_reduced_collection(self, callback_graph_builder, extend_previous_callback_graph):
if not extend_previous_callback_graph:
# there was no previous reduce step
log.warning("Doing band math without proper `DataCube.band()` usage. There is probably something wrong. See issue #123")
args = {
'data': {'from_node': self.builder.result_node},
# TODO: avoid hardcoded dimension name 'spectral_bands' #116
Expand Down

0 comments on commit 6a3c754

Please sign in to comment.