Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roslyn] Add support for constructor/method signature intellisense #224

Open
jtbm37 opened this issue May 7, 2016 · 10 comments
Open

[Roslyn] Add support for constructor/method signature intellisense #224

jtbm37 opened this issue May 7, 2016 · 10 comments

Comments

@jtbm37
Copy link
Contributor

jtbm37 commented May 7, 2016

Roslyn has support for it here and has tests.

We just need to show the signature when typing (.

Optionally user can call the function when point is inside parentheses.

@jtbm37
Copy link
Contributor Author

jtbm37 commented May 7, 2016

We should also probably show it when typing a , inside parentheses but also when there is only one opening bracket.

@mikavilpas
Copy link
Contributor

👍
What do you think, would eldoc suffice? We display current type information with eldoc.

On the other hand, for example lispy goes the extra step and displays stuff like this in an overlay:

overlay

@jtbm37
Copy link
Contributor Author

jtbm37 commented May 10, 2016

I am thinking we should use company so we can expand the selection like a snippet and then filling in each parameters by tabbing through.
We could even use company quickhelp to display extra information.

I am not sure how eldoc would display 5 constructor/method overloads.

@mikavilpas
Copy link
Contributor

Ah I see what you mean. Eldoc is clearly out of the question.
I haven't really looked at the server api yet.

2016-05-11 1:12 GMT+03:00 jtbm37 notifications@github.com:

I am thinking we should use company so we can expand the selection like a
snippet and then filling in each parameters by tabbing through.
We could even use company quickhelp
https://github.com/expez/company-quickhelp to display extra information.

I am not sure how eldoc would display 5 constructor/method overloads.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#224 (comment)

@jtbm37
Copy link
Contributor Author

jtbm37 commented May 12, 2016

Roslyn has now a new completion API available. This is very exciting.

It needs to be implemented in omnisharp-roslyn. When it is, we could have new completion capabilities like in object initializer which we previously did not.

@mikavilpas
Copy link
Contributor

This is exciting!
Let's keep an eye on that. I wonder if the completion API will change, or if it's just going to be an internal change with no visible changes to the outside.

@jtbm37
Copy link
Contributor Author

jtbm37 commented May 12, 2016

How is that looking ?
selection_004

@mikavilpas
Copy link
Contributor

looking great!

@willl
Copy link
Member

willl commented Jun 14, 2016

@jtbm37 Completion API has now been merged into omnisharp-roslyn: OmniSharp/omnisharp-roslyn#583 :)

@jtbm37
Copy link
Contributor Author

jtbm37 commented Jun 15, 2016

@willl Thanks. I will surely be testing that fairly soon. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants