Use new Roslyn Completion List API for IntelliSense

[nosami]

Internal, but much better. Handles keywords, snippets, named parameters, object initializer etc.

https://github.com/dotnet/roslyn/blob/47ff630cc838b56248022c1d494299f35daec474/src/Features/CSharp/Completion/CSharpCompletionService.cs

var completionService = new CSharpCompletionService();
var t = await completionService.GetGroupsAsync(document, position, new mca.Completion.CompletionTriggerInfo(), completionService.GetDefaultCompletionProviders(), new CancellationToken());

[davidfowl]

epic

[jrieken]

👍 reflection ftw

[stirno]

I have a working impl of this in our codebase but it throws under Mono presently with a not-very-helpful error. Haven't had a chance to dig through that yet.

Also theres an internal extension method on document to help create the service, might be better to use that in case it gets more MEFy:

var completionService = document.GetLanguageService<ICompletionService>();

[Pilchie]

Nice! I would like to make something like that public at some point after I make something like ICompletionProvider public (my current side project).

[nosami]

Seems that the features assembly doesn't yet have a nuget package - dotnet/roslyn#572

[aelij]

@Pilchie, while you're doing that, how about moving ISignatureHelpProvider to the Features assembly and making it public as well? :)
It has no dependency on the VS SDK, so it should be easy (I know because I've done it).

@nosami I think OmniSharp would also benefit from this. The signature help provider is much better at providing both method and argument IntelliSense than the Recommender.

[Pilchie]

Tagging @DustinCampbell on this too.

[DustinCampbell]

I'm going to tracking this over at dotnet/roslyn#3538

[DustinCampbell]

And here: dotnet/roslyn#3540

[khellang]

👍

[DustinCampbell]

And if anyone's interested, the branch I'm working out of is at https://github.com/DustinCampbell/roslyn/tree/completion-api.

[tpetrina]

Hi @DustinCampbell, can you please give an example on how to use the completion API in your branch?

[DustinCampbell]

Patience. 😄 I'm actively integrating it back into Roslyn proper as an internal API. Once that happens, I'll run it through a formal API design process and we'll make it public.

[tpetrina]

OK, thanks. I was under the impression that you are nearly done :P

[DustinCampbell]

Getting pretty close (for example: dotnet/roslyn#3955). I've been on vacation the past several weeks so work halted for a bit. I'm moving much faster now.

[Vidhyakp]

I need a script editor that provides intellisense and squiggling.

With Recommender I am not able to get the "keywords" which was possible ICompletionService which was public in earlier versions of Roslyn.

Can you please let me know whether we have any thing similar to ICompletionService that is public in the latest version or any update on making "ICompletionService" public?

[DustinCampbell]

This was implemented in Roslyn with #8170. A public completion API is now available. I'll own integrating it in OmniSharp.

[ivanz]

What is the status of this? I see that a pull requests #583 was merged in June which seems to implement the new completion API, but when I compile the dev branch and point my VSCode workspace to it - I see no change in auto-completion of object initializers and constructors - still no show? (dotnet/vscode-csharp#260 ) Isn't the new completion API supposed to resolve this?

    "csharp.omnisharp" : "C:/code/omnisharp-roslyn/artifacts/publish/OmniSharp/default/netcoreapp1.0/OmniSharp.exe"

[DustinCampbell]

#583 uses the new completion API with the same OmniSharp end point. Currently, it only uses the completion API to retrieve the available keywords (which allowed me to remove a ton of code from OmniSharp). I've been looking at this and believe that a new v2 end point will be needed to properly target the completion API.

[Novack]

Following.

[Novack]

Any progress or changes?

[kzu]

@DustinCampbell so now there's even a v3 of the protocol https://microsoft.github.io/language-server-protocol/specification :). I'd love to see this happening...

[DustinCampbell]

@kzu -- what, specifically, would you like to see? The work tracked here isn't related to LSP.

[kzu]

Would like to see the full completion, and ideally even with some way to configure additional completion providers exported somehow to OmniSharp :)