Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: When updating total weight, automatically update length #79

Closed
pixelicous opened this issue Oct 20, 2020 · 7 comments
Closed

Comments

@pixelicous
Copy link

If you forget to update your spool, then you go ahead and update it manually, the weight is updated but the length used isn't updated automatically.. which is a bit weird because for any other change the system does, it does it.

Would be great to have it done automatically..

@stale
Copy link

stale bot commented Nov 19, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Nov 19, 2020
@ThomDietrich
Copy link

I agree. Generally it would be nice if data entered for a spool is used to fill the remaining fields

@stale stale bot removed the status: markedForAutoClose Issue will be closed automatically label Nov 19, 2020
@stale
Copy link

stale bot commented Dec 20, 2020

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

@stale stale bot added the status: markedForAutoClose Issue will be closed automatically label Dec 20, 2020
@stale stale bot closed this as completed Dec 30, 2020
@OllisGit
Copy link
Owner

Hi @pixelicous,
thanks for the request. Automatically updating fields is a tricky thing.

We have a couple of fields that have a "relationship", but what is the best strategy for autoupdate?

If I enter/adjust the used weight the used length should calculated, right? But what about the other way around.
Adjust the used length should the used weight also update (then we hava a circle)...which field is the "master"?

Maybe a button on each filed that can be execute the calculation of the current values, but then I think the UI is a little bit "overloaded".

Do you have an idea how to solve this or a suggestion for the UI?

BR
Olli
PS. Sorry, for being late to the party, but I made a "Octoprint sabatical" (no coding, no printing) the last months.

@Sembazuru
Copy link

If I enter/adjust the used weight the used length should calculated, right? But what about the other way around.
Adjust the used length should the used weight also update (then we hava a circle)...which field is the "master"?

Technically, isn't the used length really the master during usage? AFAIK scrubbing the gcode for usage really only shows length (the g-code for extrude is in unit of length, not weight or even volume). So when automatically updating the usage the original data is length. Used weight is calculated from length based on entered density and diameter (used to calculate cross-sectional area) in OctoPrint either by g-code parsing before printing or g-code capture at the serial port. If there is are numbers provided by the slicer that the g-code parser reads, those are probably converted from volume of the tool path.

But, when entering a brand new spool, except for a few manufacturers the master field there is the weight. (Only a few manufacturers actually tell you the length of filament put on the spool.)

Do you have an idea how to solve this or a suggestion for the UI?

For the pairs weight/length, my thought is one should be updated when the other is changed (or looses focus). The question in my mind is which one gets changed if either the density or the diameter get updated? Maybe both marked red until one gets and loses focus to update the other?

@OllisGit
Copy link
Owner

OllisGit commented Jan 7, 2022

releated to PR #206

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Jan 7, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner

Hi!
The mentioned PR is now in the latest release!

Because I have a lot of issues related the weight calculation I close this issue to get a more "up to date overview" in the issue-tracker.
If you found an issue in the latest version feel free to raise a new issue!

@OllisGit OllisGit removed the status: inNextRelease Will be implemented/fixed in next release label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants