Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database call error in methode loadCatalogColors #210

Closed
d4rken opened this issue Oct 24, 2021 · 7 comments
Closed

Database call error in methode loadCatalogColors #210

d4rken opened this issue Oct 24, 2021 · 7 comments
Labels
type: bug Something isn't working

Comments

@d4rken
Copy link

d4rken commented Oct 24, 2021

After update to 1.5.0

SPM:ERROR: DatabaseManager
Database call error in methode loadCatalogColors. See OctoPrint.log for details!

Log

2021-10-24 19:02:15,542 - octoprint.plugins.SpoolManager.DatabaseManager - INFO - Database connection succesful. Checking Scheme versions
2021-10-24 19:02:15,545 - octoprint.plugins.SpoolManager.DatabaseManager.SQL - DEBUG - ('SELECT DISTINCT "t1"."color", "t1"."colorName" FROM "spo_spoolmodel" AS "t1"', [])
2021-10-24 19:02:15,546 - octoprint.plugins.SpoolManager.DatabaseManager - ERROR - Database call error in methode loadCatalogColors
Traceback (most recent call last):
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/octoprint_SpoolManager/DatabaseManager.py", line 703, in _handleReusableConnection
    return databaseCallMethode()
  File "/home/pi/OctoPrint/venv/lib/python3.7/site-packages/octoprint_SpoolManager/DatabaseManager.py", line 1036, in databaseCallMethode
    "colorId": spool.color + ";" + spool.colorName,
TypeError: can only concatenate str (not "NoneType") to str
2021-10-24 19:02:15,546 - octoprint.plugins.SpoolManager - WARNING - SendToClient: error#DatabaseManager#Database call error in methode loadCatalogColors. See OctoPrint.log for details!
@OllisGit OllisGit added status: analysing status: waitingForFeedback Wating for Customers feedback type: bug Something isn't working labels Oct 24, 2021
@OllisGit
Copy link
Owner

Hi @d4rken,

hmmm... a Spool without a color should not be possible.
Please provide me your database, so I can analyse the bug deeply.

You can download the db via the plugin-settings.
image

@d4rken
Copy link
Author

d4rken commented Oct 24, 2021

Maybe that's also why I'm always seeing this error, despite everything working?

Screenshot from 2021-10-24 20-40-29

spoolmanager.zip

@d4rken
Copy link
Author

d4rken commented Nov 2, 2021

Viewing the db, there were 5 entries without colorName, afaict this is not a "mandatory" item to input in the UI, right?

I used the plugin UI to view each of the spools without colorName in the DB, they all showed a color name in the color name field.

I toggled the colors for each spool (select a different color then the original one again) and saved them.

The error is gone now.

I still see Plugin not working, because of Database issues. Check Plugin-Settings! but that was also visible before.

@OllisGit OllisGit added status: inNextRelease Will be implemented/fixed in next release and removed status: analysing status: waitingForFeedback Wating for Customers feedback labels Jan 7, 2022
OllisGit added a commit that referenced this issue Jan 12, 2022
@OllisGit
New Version 1.6.0
02e6231 
- E release-channles
- E stale-bot via github-actions
- E #79, #87, #99, #119, #157, #176, #202, weight calculation during editing PR #206, thx al lot @TiziG
- E #106 switching from travis to github-actions
- E #107, #215 database-settings in the log will only be shown, if sql-logging is enabled
- E #170 inform user about switching a spool already selected
- E #213 sort/filter options in spool selection dialog
- E Extrusion-Debugging: Show current extrusion during printing

- B #188 touchUI conflict
- B #193, #196 sorting/showing of remaining weight
- B #205 changed to "browser-native" date/time picker
- B #210 loadCatalogColors when color name is blank
- B #211 button text changed
- B #212 import CSV only if printer in idle-mode
- B #216 FilamentManager and SpoolManager used same viewmodel
- B #217 when print is paused the extruded filament is assigned to the spool and the counter is reseted
@OllisGit
Copy link
Owner

Hi,
in the latest version the issue should be fixed.
Please test and give a feedback.

Thx in advance
Olli

@OllisGit OllisGit added status: waitingForTestFeedback and removed status: inNextRelease Will be implemented/fixed in next release labels Jan 12, 2022
@d4rken
Copy link
Author

d4rken commented Jan 12, 2022

Yep, seems fixed, thanks!

This error still shows though:
#210 (comment)

@OllisGit
Copy link
Owner

@d4rken please attach the current octoprint.log if you still see the database error.

@d4rken
Copy link
Author

d4rken commented Jan 13, 2022 •
edited
Loading

I don't think it is necessarily related to this bug, closing this in favor of #223.

Thanks for the fix! ❤️

@d4rken d4rken closed this as completed Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d4rken @OllisGit