Fix disabling the nonce cache on the sequencer #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
Codecov Report
@@ Coverage Diff @@
## master #1523 +/- ##
===========================================
+ Coverage 35.55% 49.65% +14.10%
===========================================
Files 59 259 +200
Lines 2956 31233 +28277
Branches 555 555
===========================================
+ Hits 1051 15509 +14458
- Misses 1905 13531 +11626
- Partials 0 2193 +2193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our check of the cache being nil broke with our most recent lru cache implementation, so this adds an additional Size check.