Merge pull request #1523 from OffchainLabs/fix-disable-nonce-cache

Fix disabling the nonce cache on the sequencer

arbnode/sequencer.go

@@ -205,7 +205,7 @@ func (c *nonceCache) Update(header *types.Header, addr common.Address, nonce uin
 }
 
 func (c *nonceCache) Finalize(block *types.Block) {
-	// Note: we don't use c.Matches here because the header will have changed
+	// Note: we don't use c.matches here because the header will have changed
 	if c.block == block.ParentHash() {
 		c.block = block.Hash()
 		c.dirty = nil
@@ -215,7 +215,7 @@ func (c *nonceCache) Finalize(block *types.Block) {
 }
 
 func (c *nonceCache) Caching() bool {
-	return c.cache != nil
+	return c.cache != nil && c.cache.Size() > 0
 }
 
 func (c *nonceCache) Resize(newSize int) {

util/containers/lru.go

@@ -12,6 +12,7 @@ import (
 type LruCache[K comparable, V any] struct {
 	inner   *simplelru.LRU[K, V]
 	onEvict func(key K, value V)
+	size    int
 }
 
 func NewLruCache[K comparable, V any](size int) *LruCache[K, V] {
@@ -27,6 +28,7 @@ func NewLruCacheWithOnEvict[K comparable, V any](size int, onEvict func(K, V)) *
 	return &LruCache[K, V]{
 		inner:   inner,
 		onEvict: onEvict,
+		size:    size,
 	}
 }
 
@@ -83,6 +85,10 @@ func (c *LruCache[K, V]) Len() int {
 	return c.inner.Len()
 }
 
+func (c *LruCache[K, V]) Size() int {
+	return c.size
+}
+
 func (c *LruCache[K, V]) Clear() {
 	if c.inner == nil {
 		return
@@ -102,4 +108,5 @@ func (c *LruCache[K, V]) Resize(newSize int) {
 	} else {
 		c.inner.Resize(newSize)
 	}
+	c.size = newSize
 }