Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommandHandler & Fixes the time command #451

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

Tides
Copy link
Member

@Tides Tides commented Sep 20, 2024

This updates the command handler to recognize if a type is a CommandGroup and register that alone. Also fixes the CommandRegistry from registering subcommands from a group as a root command instead of a child command.

Closes #282

@github-actions github-actions bot added api Relates to Obsidian.API commands Relates to Obsidian.Commands labels Sep 20, 2024
@Tides Tides added server Relates to the server implementation priority: high Very important labels Sep 20, 2024
Copy link
Member

@Naamloos Naamloos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh lgtm

@Tides Tides merged commit 54d0939 into 1.21.x Sep 24, 2024
2 checks passed
@Tides Tides deleted the fix-time-command branch September 24, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to Obsidian.API commands Relates to Obsidian.Commands priority: high Very important server Relates to the server implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make /time command behave like vanilla
2 participants