Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /time command behave like vanilla #282

Closed
4 tasks
Craftplacer opened this issue Sep 17, 2022 · 3 comments · Fixed by #451
Closed
4 tasks

Make /time command behave like vanilla #282

Craftplacer opened this issue Sep 17, 2022 · 3 comments · Fixed by #451
Labels
commands Relates to Obsidian.Commands enhancement New feature or request good first issue Good for newcomers

Comments

@Craftplacer
Copy link
Collaborator

Craftplacer commented Sep 17, 2022

  • It does not have set, add sub-commands, but can only set a certain time (It only works like /time set)
  • The command does not add the number of days to Day (Days through F3)
  • If you write a number greater than Int32.MaxValue, the command will return an error only to the console.
  • If no time was provided, the time will be set to 1337 instead.
@Craftplacer Craftplacer added enhancement New feature or request good first issue Good for newcomers commands Relates to Obsidian.Commands labels Sep 17, 2022
@hikaru1337
Copy link

The message about 1337 was more like finding an easter egg, please leave it)

@Naamloos
Copy link
Member

Thanks for opening the issue craft <3

@ktalap
Copy link

ktalap commented Aug 4, 2023

World's total time is a different task, doesn't depend on the /time command. The overflow is also done separately, commands do not handle that in Obsidian as I understand, they just get values in arguments, if it's overflowing they get nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands Relates to Obsidian.Commands enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants