Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /time command behave like vanilla #381

Closed
wants to merge 0 commits into from

Conversation

ktalap
Copy link

@ktalap ktalap commented Aug 4, 2023

I am not sure how to implement /time command without arguments and /time query command which also takes no arguments.
What have been implemented:

  • set command
  • add command

#282
In the issue world's total time is a different task, doesn't depend on the /time command. The overflow is also done separately, commands do not handle that in Obsidian as I understand, they just get values in arguments, if it's overflowing they get nothing.

@ktalap
Copy link
Author

ktalap commented Aug 6, 2023

Tagged: @Naamloos @Tides @Craftplacer @Seb-stian @Jonpro03
Can someone at least give some feedback guys? I will fix the code if needed.

@Tides
Copy link
Member

Tides commented Aug 8, 2023

Hey, I see you're using parameters instead of creating a sub command. I would recommend staying away from this until we re-implement a fixed command api/system~

@ktalap
Copy link
Author

ktalap commented Aug 8, 2023

Hey, I see you're using parameters instead of creating a sub command. I would recommend staying away from this until we re-implement a fixed command api/system~

Ok, any suggestions on what should I work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants