fixbuild: bump linter version #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
==========================================
+ Coverage 56.78% 57.86% +1.07%
==========================================
Files 208 208
Lines 29235 29217 -18
==========================================
+ Hits 16601 16906 +305
+ Misses 10809 10483 -326
- Partials 1825 1828 +3 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 18, 2024
Merged
pinebit
approved these changes
Jul 18, 2024
Fix previously uncaught by linter revive linters Fix all other revive linters Fix previously uncaught by linter revive linters Fix previously uncaught by linter revive linters round 2 Fix previously uncaught by linter revive linters round 2 Fix previously uncaught by linter revive linters round 3
Update for loops over integers with range round 2 Update for loops over integers with range round 3 Update for loops over integers with range round 4
Fix perfsprint linter round 2 Fix perfsprint linter round 2 Fix perfsprint linter round 3 Fix perfsprint linter round 4
KaloyanTanev
force-pushed
the
kalo/bump-golangci-lint-v1.59.1
branch
2 times, most recently
from
cd61973
to
32d405e
Compare
KaloyanTanev
force-pushed
the
kalo/bump-golangci-lint-v1.59.1
branch
from
32d405e
to
28840e8
Compare
|
gsora
approved these changes
Jul 25, 2024
pinebit
approved these changes
Jul 25, 2024
KaloyanTanev
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci-lint was on older version that did not support go1.22 yet, which causes false alarms.
This update introduced a lot of new, deprecated and modified linters. There are a lot of changes in the files and I would advise for easier review to go over the commits, as I've tried to keep them concise, so there are only changes from one linter or if many, the changes are little. Most eye catching changes in the files are:
testifylint: we had quite a lot of assertions inside of go routines, this is a bit of a red flag, because as observed in this small example, a failed assertion might or might not be caughtgolangci-lintused in pre-commit was a defaultgolangci-lintfrom here, using its default config, which made the linter pass locally all the time. This is something I've observed multiple times (dating back to my very first PR :)). Now the pre-commit hook is running the locally installedgolangci-linttool and it checks if the version is the same as the one in the pipelines.max-same-issues=0andmax-issues-per-linter=0so there is no limit on what we see in the output. Previously the default of 3 was used, so if there were hundreds of errors with one linter, it would have displayed only 3, which made it quite a hassle to fix.golangci-lintaction's version to v6. It now points where exactly the issue is, which is great!category: fixbuild
ticket: #3179