Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: charon test peers ping charon relays #3177

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

KaloyanTanev
Copy link
Contributor

@KaloyanTanev KaloyanTanev commented Jul 18, 2024

Add ping tests (ping and RTT measurement) towards charon relays.

category: feature
ticket: #3205

@KaloyanTanev KaloyanTanev self-assigned this Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 79.72973% with 30 lines in your changes missing coverage. Please review.

Project coverage is 58.08%. Comparing base (34f7d83) to head (ad05aee).

Files Patch % Lines
cmd/testpeers.go 79.72% 19 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
+ Coverage   57.86%   58.08%   +0.21%     
==========================================
  Files         209      209              
  Lines       29356    29495     +139     
==========================================
+ Hits        16988    17133     +145     
+ Misses      10529    10512      -17     
- Partials     1839     1850      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev
Copy link
Contributor Author

golangci-lint should pass after #3178 is merged.

@KaloyanTanev KaloyanTanev force-pushed the kalo/test-peers-command-relay branch from ffca2fb to ad05aee Compare July 25, 2024 14:06
@KaloyanTanev KaloyanTanev force-pushed the kalo/test-peers-command-relay branch from ad05aee to 3b2abc2 Compare July 25, 2024 17:29
Copy link

sonarcloud bot commented Jul 25, 2024

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 25, 2024
@obol-bulldozer obol-bulldozer bot merged commit 4249725 into main Jul 25, 2024
11 checks passed
@obol-bulldozer obol-bulldozer bot deleted the kalo/test-peers-command-relay branch July 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants