cmd: exit with validator index, allow BN URLs #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specifying more than one beacon node to use with the `--beacon-node-endpoints` flag. Users can now sign exits directly with a validator index rather than specifying its public key. If both are specified, validator index takes precedence. `sign` checks that the specified validator index exists in the cluster lock before proceeding.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 56.85% 56.80% -0.06%
==========================================
Files 208 208
Lines 29148 29190 +42
==========================================
+ Hits 16571 16580 +9
- Misses 10740 10771 +31
- Partials 1837 1839 +2 ☔ View full report in Codecov by Sentry. |
|
Need to clarify what i mean here in more detail, but we need to check if this will work for stakewise exit prediction. Update: Can
(Also asked Luke whether the API would have a problem with a single validator sending sigs for more than one index, he doesn't think so) |
gsora
changed the title
gsora
changed the title
If both validator public key and index are provided, don't query the beacon node for validator liveliness (i.e. the validator has been created on the beacon chain). Allows pre-signing exits for validator that are yet to be created, some third-parties need this functionality.
pinebit
reviewed
May 31, 2024
pinebit
approved these changes
May 31, 2024
|
KaloyanTanev
approved these changes
Jun 3, 2024
gsora
added
the
merge when ready
KaloyanTanev
pushed a commit
that referenced
this pull request
Jun 5, 2024
Allow specifying more than one beacon node to use with the `--beacon-node-endpoints` flag. Users can now sign exits directly with a validator index rather than specifying its public key. If both are specified, validator liveliness (i.e. whether or not the validator exists on the beacon chain) is not checked. `sign` checks that the specified validator index exists in the cluster lock before proceeding. category: feature ticket: #3104 Closes #3104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying more than one beacon node to use with the
--beacon-node-endpointsflag.Users can now sign exits directly with a validator index rather than specifying its public key.
If both are specified, validator liveliness (i.e. whether or not the validator exists on the beacon chain) is not checked.
signchecks that the specified validator index exists in the cluster lock before proceeding.category: feature
ticket: #3104
Closes #3104