-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presign Exit by validator index #3104
Labels
protocol
Protocol Team tickets
Comments
LFTM. Should we do this by v1? |
yeah may as well? |
Hey team! Please add your planning poker estimate with Zenhub @gsora @KaloyanTanev @pinebit |
obol-bulldozer bot
pushed a commit
that referenced
this issue
Jun 4, 2024
Allow specifying more than one beacon node to use with the `--beacon-node-endpoints` flag. Users can now sign exits directly with a validator index rather than specifying its public key. If both are specified, validator liveliness (i.e. whether or not the validator exists on the beacon chain) is not checked. `sign` checks that the specified validator index exists in the cluster lock before proceeding. category: feature ticket: #3104 Closes #3104
KaloyanTanev
pushed a commit
that referenced
this issue
Jun 5, 2024
Allow specifying more than one beacon node to use with the `--beacon-node-endpoints` flag. Users can now sign exits directly with a validator index rather than specifying its public key. If both are specified, validator liveliness (i.e. whether or not the validator exists on the beacon chain) is not checked. `sign` checks that the specified validator index exists in the cluster lock before proceeding. category: feature ticket: #3104 Closes #3104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🎯 Problem to be solved
Right now you must exit a validator by its
distributed_validator_public_key
, this can be confusing as it is not the public key of the partial nor is it the same name as the flag in this command--validator-public-key
. Most humans can parse the 6/7 digit validator index much more effectively than the BLS pubkey for valdiators, and I think it would be more convenient to handle and reason about when using these exit commands.🛠️ Proposed solution
It might be a big ux improvement to also add
--validator-index
as an alternative to--validator-public-key
.Technically we might even be able to skip the
beacon-node-url
flag fromcharon exit sign
if it was only being used to retrieve the state/index anyways. (While i write this, is there any chance we can edit this/alias thebeacon-node-url
flag to bebeacon-node-endpoints
likecharon run
? can imagine lots of people being caught by that gotcha otherwise, imo we should favour consistency.Describe the solution to be implemented
🧪 Tests
The text was updated successfully, but these errors were encountered: