Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: integrating go-eth2-client@v0.21.1 #2986

Merged
merged 40 commits into from
May 6, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Mar 22, 2024

Integrating the new version of go-eth2-client, resolving breaking changes, etc.

Known issues: attestantio/go-eth2-client#118 & attestantio/go-eth2-client#119

TODOs

  • Integrate v0.21.0
  • Integrate v0.21.1 (with bugfixes)
  • Test with simnet
  • Improve test coverage
  • Investigate latest teku VC not querying BN

category: feature
ticket: #2936

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 87.00855% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 56.35%. Comparing base (aaf1730) to head (61eda91).

Files Patch % Lines
core/tracker/inclusion.go 9.52% 17 Missing and 2 partials ⚠️
core/signeddata.go 88.34% 8 Missing and 4 partials ⚠️
core/ssz.go 87.95% 8 Missing and 2 partials ⚠️
app/eth2wrap/lazy.go 47.05% 6 Missing and 3 partials ⚠️
app/eth2wrap/eth2wrap_gen.go 0.00% 8 Missing ⚠️
app/eth2wrap/multi.go 94.82% 6 Missing ⚠️
core/validatorapi/router.go 95.19% 3 Missing and 2 partials ⚠️
app/eth2wrap/synthproposer.go 33.33% 3 Missing and 1 partial ⚠️
app/app.go 0.00% 1 Missing ⚠️
core/dutydb/memory.go 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   54.54%   56.35%   +1.80%     
==========================================
  Files         207      208       +1     
  Lines       29165    28846     -319     
==========================================
+ Hits        15908    16255     +347     
+ Misses      11417    10789     -628     
+ Partials     1840     1802      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit changed the title *: integrating go-eth2-client@v0.21.0 *: integrating go-eth2-client@v0.21.1 Mar 27, 2024
app/eth2wrap/eth2wrap_test.go Outdated Show resolved Hide resolved
app/eth2wrap/eth2wrap_test.go Show resolved Hide resolved
app/eth2wrap/multi.go Show resolved Hide resolved
app/eth2wrap/multi.go Show resolved Hide resolved
core/types.go Show resolved Hide resolved
Copy link
Collaborator

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, I believe this PR is great!

We should create a new core team cluster ASAP and test it.

Or at the very least, have QA try break it.

core/fetcher/fetcher.go Outdated Show resolved Hide resolved
core/signeddata.go Show resolved Hide resolved
core/ssz.go Show resolved Hide resolved
core/tracker/inclusion.go Show resolved Hide resolved
docs/architecture.md Show resolved Hide resolved
testutil/integration/simnet_test.go Show resolved Hide resolved
@ObolNetwork ObolNetwork deleted a comment from gsora Apr 3, 2024
core/validatorapi/router.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 6, 2024
@obol-bulldozer obol-bulldozer bot merged commit 11e3000 into main May 6, 2024
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/integrating-v3 branch May 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants