Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate new go-eth2-client api #2936

Closed
2 of 3 tasks
pinebit opened this issue Mar 4, 2024 · 0 comments
Closed
2 of 3 tasks

integrate new go-eth2-client api #2936

pinebit opened this issue Mar 4, 2024 · 0 comments
Assignees
@pinebit
Labels
protocol Protocol Team tickets

Comments

@pinebit
Copy link
Contributor

pinebit commented Mar 4, 2024 •
edited
Loading

🎯 Problem to be solved

Attestantio has updated their API design, integrating a new produceBlockV3 endpoint that consolidates normal and blinded block into a single structure as shown in their pull request (PR): attestantio/go-eth2-client#116. Charon needs to be adapted to align with the new API, abandoning our existing fork in favor of Attestantio's branch.

🛠️ Proposed solution

  • Review the PR and understand the changes introduced in the new produceBlockV3 endpoint.
  • Discard our current fork and switch to using Attestantio's updated branch.
  • Update Charon's codebase to comply with the new API specifications.
@pinebit pinebit self-assigned this Mar 4, 2024
@github-actions github-actions bot added the protocol Protocol Team tickets label Mar 4, 2024
This was referenced Mar 20, 2024
Closed
Closed
Closed
Closed
Closed
Merged
obol-bulldozer bot pushed a commit that referenced this issue May 6, 2024
@pinebit
*: integrating go-eth2-client@v0.21.1 (#2986)
11e3000 
Integrating the new version of go-eth2-client, resolving breaking changes, etc.

Known issues: ~attestantio/go-eth2-client#118 & ~attestantio/go-eth2-client#119

TODOs
- [x] Integrate v0.21.0
- [x] Integrate v0.21.1 (with bugfixes)
- [x] Test with simnet
- [x] Improve test coverage
- [x] Investigate latest teku VC not querying BN

category: feature
ticket: #2936
@pinebit pinebit closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinebit pinebit

Labels
protocol Protocol Team tickets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pinebit