Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons tooltips anchor tags migration to chakraUI #715

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dishant1804
Copy link
Collaborator

@Dishant1804 Dishant1804 commented Feb 2, 2025

Resolves #645

Migrated all the tooltips, buttons and anchor tags to equivalent chakraUI components

@Dishant1804
Copy link
Collaborator Author

@arkid15r I've migrated the necessary components mentioned in the issue. Please review it and let me know if any changes are required :)

@Dishant1804 Dishant1804 changed the title Buttons tooltips anchor migration Buttons tooltips anchor tags migration to chakraUI Feb 2, 2025
@github-actions github-actions bot added the schema label Feb 3, 2025
Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great migration! Thank you for updating these!

One issue I noticed:
in the light mode when some buttons in focus state now have this dark border (that is also kind of a pixel off the actual border 🤔 ). Can we get rid of this?

I found two instances of this, but there might be more. Ones that I found are on the User details page and on the issue details modal.
Screenshot 2025-02-02 at 6 49 08 PM
Screenshot 2025-02-02 at 6 49 21 PM

@Dishant1804
Copy link
Collaborator Author

Overall great migration! Thank you for updating these!

One issue I noticed:
in the light mode when some buttons in focus state now have this dark border (that is also kind of a pixel off the actual border 🤔 ). Can we get rid of this?

I found two instances of this, but there might be more. Ones that I found are on the User details page and on the issue details modal.
Screenshot 2025-02-02 at 6 49 08 PM
Screenshot 2025-02-02 at 6 49 21 PM

Yess @kasya thank you for suggesting the changes, I'll go to the root of this issue, but for now it seems like the default chakraUI button recipe is causing this focus ring effect, I'll fix that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating Buttons and Tooltips to chakraUI
2 participants