-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Sort package lists, configure options, and other various sortable files #4563
Conversation
Thanks for your efforts. We have a number of CSV files, perhaps some could be merged? Their origin is from CVS/SVN times with a different than GitHub write access model which is no longer in place:
In case of structural changes (e.g., merging selectively) also a GUI change would be needed:
contribfile = os.path.join(os.getenv("GISBASE"), "contributors_extra.csv")
contribfile = os.path.join(os.getenv("GISBASE"), "contributors.csv")
translatorsfile = os.path.join(os.getenv("GISBASE"), "translators.csv")
label=_("%s file missing") % "translators.csv", However, maybe better done in a separate PR. |
I made a separate issue for it #4599, as indeed, it is kind of a different topic than this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
Follow up from last month's #4373.
This PR sorts sortable parts of many remaining files. Build scripts, package lists, file lists, contributors lists, etc.
I made some searches on what looked like configure flags, and packages too.
About the only thing that wasn't sorted was everything in Makefiles, like directory lists or other lists in Makefiles, and the mingw64 packages in the osgeo4w.yml workflow, as the packages weren't placed in a line-delimited list yet