Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Sort package lists and configure options in Dockerfiles #4373

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Sep 24, 2024

Package lists were unsorted, and I got tricked when adding liblapacke-dev and sorting the list thinking it was sorted (almost but not). Being unsorted makes finding a package harder. To prove this point, zlib1g-dev was listed twice in the same list because it was unsorted.

I simply used the sort lines feature of my IDE, VSCode, that is case-sensitive.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the overall structure and sample of packages here and there and I don't see any issue with this.

@echoix
Copy link
Member Author

echoix commented Sep 24, 2024

Let's wait a day or so, to let Europeans have the chance to look

@github-actions github-actions bot added the docker Docker related label Sep 24, 2024
@neteler
Copy link
Member

neteler commented Sep 24, 2024

Would it make sense, while at it, to also sort:

  • singularity/debian/singularityfile_debian
  • Vagrantfile

?

@echoix
Copy link
Member Author

echoix commented Sep 24, 2024

What are those already? Is it related to docker?

To do in the same PR or another?

@neteler
Copy link
Member

neteler commented Sep 24, 2024

Vagrant: https://grasswiki.osgeo.org/wiki/Vagrant, added by @landam

Singularity is for HPC environments, added by @lucadelu

If here or elsewhere, I cannot judge.

@echoix
Copy link
Member Author

echoix commented Sep 24, 2024

Ok, I took a quick look at it, and I'll do another PR for it, that would also do other build script that has the configure calls.

So since it isn't docker related anymore, let's just start with this one that is ready to go.

@echoix echoix changed the title docker: Sort package lists and configure option in Dockerfiles docker: Sort package lists and configure options in Dockerfiles Sep 24, 2024
@echoix echoix merged commit 8c671ca into OSGeo:main Sep 24, 2024
27 checks passed
@echoix echoix deleted the dockerfile-sort branch September 24, 2024 21:22
@neteler neteler added this to the 8.5.0 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants