-
-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Sort package lists and configure options in Dockerfiles #4373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check the overall structure and sample of packages here and there and I don't see any issue with this.
Let's wait a day or so, to let Europeans have the chance to look |
Would it make sense, while at it, to also sort:
? |
What are those already? Is it related to docker? To do in the same PR or another? |
Vagrant: https://grasswiki.osgeo.org/wiki/Vagrant, added by @landam Singularity is for HPC environments, added by @lucadelu If here or elsewhere, I cannot judge. |
Ok, I took a quick look at it, and I'll do another PR for it, that would also do other build script that has the configure calls. So since it isn't docker related anymore, let's just start with this one that is ready to go. |
Package lists were unsorted, and I got tricked when adding liblapacke-dev and sorting the list thinking it was sorted (almost but not). Being unsorted makes finding a package harder. To prove this point,
zlib1g-dev
was listed twice in the same list because it was unsorted.I simply used the sort lines feature of my IDE, VSCode, that is case-sensitive.