Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces for envvars in submit.yml.erb #202

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Conversation

matthu017
Copy link
Contributor

Used Shellwords.escape

@matthu017 matthu017 linked an issue Jun 15, 2020 that may be closed by this pull request
@matthu017
Copy link
Contributor Author

A more permanent fix would be to change script.native hash into array format but it seems like torque is the only one would need this (As it is the only one that uses send() instead of Open3.capture3() and only when script.native is a hash)

Open3.capture3 correctly submits the envvars (no shell escape needed)

@ericfranz
Copy link
Contributor

As for changing the torque adapter to use only array for native attribute, this adapter supports both hash and array and you may have seen the comment at the top:

     # FIXME: Remove the Hash option once all Interactive Apps are
     # converted to Array format

It is something we could do for 2.0 if we wanted to deprecated this, but we would need to double check and ensure all our apps use array for the native option and then some how log a deprecation warning when using the hash approach.

@ericfranz ericfranz merged commit 9eaf3cf into master Jun 20, 2020
@ericfranz ericfranz deleted the job_environment_spaces branch June 20, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job_environment doesn't handle values with spaces
2 participants