Fix spaces for envvars in submit.yml.erb (#202)

Authored-by: Matthew Hu <mhu@owens-rw02.ten.osc.edu>

lib/ood_core/job/adapters/torque.rb

@@ -1,5 +1,6 @@
 require "ood_core/refinements/hash_extensions"
 require "ood_core/job/adapters/helper"
+require 'shellwords'
 
 module OodCore
   module Job
@@ -129,6 +130,9 @@ def submit(script, after: [], afterok: [], afternotok: [], afterany: [])
               envvars.merge!   script.native.fetch(:envvars, {})
             end
 
+            # Destructively change envvars to shellescape values
+            envvars.transform_values! { |v| Shellwords.escape(v) }
+
             # Submit job
             @pbs.submit_string(script.content, queue: script.queue_name, headers: headers, resources: resources, envvars: envvars)
           else

spec/job/adapters/torque_spec.rb

@@ -317,6 +317,12 @@ def build_script(opts = {})
         it { expect(pbs).to have_received(:submit_string).with(content, queue: nil, headers: {Join_Path: "oe"}, resources: {}, envvars: {"key" => "value"}) }
       end
 
+      context "with :job_environment having spaces" do
+        before { adapter.submit(build_script(job_environment: {"key" => "value value"})) }
+
+        it { expect(pbs).to have_received(:submit_string).with(content, queue: nil, headers: {Join_Path: "oe"}, resources: {}, envvars: {"key" => "value\\ value"}) }
+      end
+
       context "with :workdir" do
         before { adapter.submit(build_script(workdir: "/path/to/workdir")) }