Skip to content
This repository has been archived by the owner on Nov 13, 2019. It is now read-only.

Handle long job name #294

Merged
merged 2 commits into from
Apr 9, 2019
Merged

Handle long job name #294

merged 2 commits into from
Apr 9, 2019

Conversation

qianyuanzhu
Copy link
Contributor

Set displayed length maximum to 80 for template table and job table
truncated
truncates

Fixed #290

Copy link
Contributor

@MorganRodgers MorganRodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The magic number 80 should be pulled out into a variable or constant.

@qianyuanzhu qianyuanzhu reopened this Apr 5, 2019
@qianyuanzhu
Copy link
Contributor Author

text-overflow: ellipsis; white-space: nowrap; overflow: hidden; requires table-layout: fixed
So the column width is fixed and I set the width of job name column to be 50% in the table.
new-name
new-name1

Copy link
Contributor

@MorganRodgers MorganRodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better solution than the fixed character count.

@MorganRodgers MorganRodgers merged commit 9224d06 into master Apr 9, 2019
@MorganRodgers MorganRodgers deleted the handle-long-name branch April 9, 2019 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants