-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Color Schemes #630
Simple Color Schemes #630
Conversation
In public/themes/ you store the .terminal versions. Did you use these to generate the theme values in public/javascripts/themes.js? Are there other formats for the themes that produce the same values? Some of the other theme formats store human readable forms of the colors, which might be nice when versioning, but it wasn't apparent to me whether https://github.com/mbadolato/iTerm2-Color-Schemes/tree/master/schemes or Xresources or vscode or another format had all the values you needed (vs code seemed to miss things like bold and cursor etc.) It isn't as important as the licenses and maybe in the README a link to the source where these were copied. |
…scheme info to README
…manually in the HTML as handlebars is currently serverside.
prepolulate hterm.defaultStorage with theme values, an hterm profile per theme, so that we can just use hterm specify the starting profile and switch by using term.setProfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me. I like the addition of whole profiles which we may be able to add to later on.
This implementation of terminal schemes does not require reconnection-improvements to work.