Simple Color Schemes #630
Merged
Simple Color Schemes #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 7, 2020 22:24
ericfranz
reviewed
Oct 9, 2020
|
In public/themes/ you store the .terminal versions. Did you use these to generate the theme values in public/javascripts/themes.js? Are there other formats for the themes that produce the same values? Some of the other theme formats store human readable forms of the colors, which might be nice when versioning, but it wasn't apparent to me whether https://github.com/mbadolato/iTerm2-Color-Schemes/tree/master/schemes or Xresources or vscode or another format had all the values you needed (vs code seemed to miss things like bold and cursor etc.) It isn't as important as the licenses and maybe in the README a link to the source where these were copied. |
…scheme info to README
…manually in the HTML as handlebars is currently serverside.
prepolulate hterm.defaultStorage with theme values, an hterm profile per theme, so that we can just use hterm specify the starting profile and switch by using term.setProfile
johrstrom
approved these changes
Feb 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of terminal schemes does not require reconnection-improvements to work.