Color Schemes In Terminal #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samirmansour noted that the failing build is due to an npm dependency conflict where it is asking which version we want to install; the question is whether this is preexisting or introduced by this PR |
ericfranz
reviewed
May 19, 2020
ericfranz
reviewed
May 19, 2020
ericfranz
reviewed
May 19, 2020
ericfranz
reviewed
May 19, 2020
ericfranz
reviewed
May 19, 2020
| }) | ||
| } | ||
|
|
||
| function rgbToHexMath (num) { |
There was a problem hiding this comment.
Add some documentation above all of these functions following https://jsdoc.app/ format
ericfranz
reviewed
May 19, 2020
ericfranz
reviewed
May 19, 2020
|
I marked this as blocked and for 2.0 - as it is a more complex solution that piggybacks off of the re-connection improvements. We are looking at a simpler solution to add sooner. |
|
Duplicate of #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch combines the ability to have sessions and the ability to change the terminals color scheme on an individual basis. To add color schemes go to ~/.config/ondemand/apps/shell/themes. To launch a new or existing terminal with a theme go to /launch endpoint.