-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Schemes In Terminal #484
Conversation
@samirmansour noted that the failing build is due to an npm dependency conflict where it is asking which version we want to install; the question is whether this is preexisting or introduced by this PR |
}) | ||
} | ||
|
||
function rgbToHexMath (num) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some documentation above all of these functions following https://jsdoc.app/ format
I marked this as blocked and for 2.0 - as it is a more complex solution that piggybacks off of the re-connection improvements. We are looking at a simpler solution to add sooner. |
Duplicate of #630 |
This branch combines the ability to have sessions and the ability to change the terminals color scheme on an individual basis. To add color schemes go to ~/.config/ondemand/apps/shell/themes. To launch a new or existing terminal with a theme go to /launch endpoint.