Refactor sshhost whitelist #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to optional chaining
This was
linked to
issues
Jun 3, 2020
|
Branch using destructuring here: #519 |
ericfranz
reviewed
Jun 4, 2020
apps/shell/app.js
Outdated
| .filter(config => (config.v2 && config.v2.login && config.v2.login.host) && ! (config.v2 && config.v2.metadata && config.v2.metadata.hidden)) | ||
| .forEach((config) => { | ||
| let host = config.v2.login.host; //Already did checking above | ||
| let isDefault = config.v2 && config.v2.login && config.v2.login.default; |
There was a problem hiding this comment.
We filter out configs that do not have v2.login.host set, so we don't need to repeat the checks here. config.v2.login.default is fine.
There was a problem hiding this comment.
We will have to make a change to:
https://osc.github.io/ood-documentation/master/installation/cluster-config-schema.html
will return undefined if doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses chaining instead of destructuring to make code more readable