Added whitelist and default sshhost #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 29, 2020
msquee
reviewed
May 29, 2020
ericfranz
reviewed
May 29, 2020
ericfranz
reviewed
May 29, 2020
ericfranz
reviewed
May 29, 2020
msquee
reviewed
May 29, 2020
msquee
reviewed
May 29, 2020
msquee
reviewed
May 29, 2020
msquee
reviewed
May 30, 2020
msquee
reviewed
May 30, 2020
|
Refactored branch using chaining here: #522 |
ericfranz
reviewed
Jun 8, 2020
msquee
reviewed
Jun 16, 2020
ericfranz
reviewed
Jun 19, 2020
ericfranz
reviewed
Jun 19, 2020
ericfranz
reviewed
Jun 23, 2020
ericfranz
reviewed
Jun 24, 2020
ericfranz
previously approved these changes
Jun 26, 2020
ericfranz
reviewed
Jun 26, 2020
ericfranz
reviewed
Jun 26, 2020
Added default_sshhost to allow for /default/ in the url Generated by cluster configs and environment
matthu017
force-pushed
the
sshhost_whitelist
branch
from
4435b85
to
2328812
Compare
ericfranz
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #508 and #507