-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dashboard navbar in the file editor #3646
Conversation
That layout seems fine to me in the sense that it's a panel to the left. Tests are failing because we need to reset the page |
spec/e2e/browser_spec.rb
Outdated
expect(browser.title).to eq('File Editor - Open OnDemand - .bashrc') | ||
expect(browser.title).to eq('Dashboard - Open OnDemand') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we shouldn't change the test, we should change the application. Page titles are actually very important for blind users to indicate what that page is all about as they go through their open tabs.
This reverts commit 368d097.
@@ -1,5 +1,239 @@ | |||
<div class="d-flex flex-row flex-grow-1"> | |||
<div class="flex-sm-column card mx-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for now, though I think it can still be enhanced. Maybe the left panel is collapsible? IDK - it just takes up a lot of real estate.
Fixes #1864
Uses the dashboard navbar by using the application layout for the editor. As a result, configurations needed to be moved to a side panel.
I'm not sure if this is the best layout for these options - maybe they would be better placed above or below the editor?
These changes also cause alerts to appear in the editor, which differs from existing functionality.