Use dashboard navbar in the file editor #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That layout seems fine to me in the sense that it's a panel to the left. Tests are failing because we need to reset the page |
johrstrom
reviewed
Jun 28, 2024
spec/e2e/browser_spec.rb
Outdated
| expect(browser.title).to eq('File Editor - Open OnDemand - .bashrc') | ||
| expect(browser.title).to eq('Dashboard - Open OnDemand') |
There was a problem hiding this comment.
No we shouldn't change the test, we should change the application. Page titles are actually very important for blind users to indicate what that page is all about as they go through their open tabs.
This reverts commit 368d097.
johrstrom
reviewed
Jul 1, 2024
| @@ -1,5 +1,239 @@ | |||
| <div class="d-flex flex-row flex-grow-1"> | |||
| <div class="flex-sm-column card mx-2"> | |||
There was a problem hiding this comment.
Dont' know how big your screen is - but this renders very large for me (half the page) - I'm guessing because the filename is so long.
|
Though the text wraps, it seems to break on any character. Is there a way to break only on '/' characters? |
johrstrom
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864
Uses the dashboard navbar by using the application layout for the editor. As a result, configurations needed to be moved to a side panel.
I'm not sure if this is the best layout for these options - maybe they would be better placed above or below the editor?
These changes also cause alerts to appear in the editor, which differs from existing functionality.