Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added module support for custom javascript files #3499

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Added module support for custom javascript files #3499

merged 2 commits into from
Apr 10, 2024

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Apr 9, 2024 •
edited
Loading

Adds support for type metadata for custom JavaScript files.

This change is backwards compatible.

    custom_javascript_files:
      - src: "/js/file.js"
        type: "module"
      - "/js/other_file.js"

Possible fix for #3487

@abujeda abujeda force-pushed the 3487_custom_js_module_support branch from 7d4a4ad to 4fe412a Compare April 9, 2024 14:44
@abujeda abujeda force-pushed the 3487_custom_js_module_support branch from 4fe412a to d5d9d95 Compare April 10, 2024 16:59
johrstrom
johrstrom approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up.

@johrstrom johrstrom merged commit bc475c5 into OSC:master Apr 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abujeda @johrstrom @osc-bot