Added debug statement for flaky favorites test

apps/dashboard/test/system/batch_connect_test.rb

@@ -1361,7 +1361,7 @@ def make_bc_app(dir, form)
       click_on('Select Path')
 
       # shows the OodFilesApp.candidate_favorite_paths favorites
-      favorites = all('#favorites li', wait: 30)
+      favorites = get_favorites
       assert_equal(2, favorites.size)
       assert_equal('/tmp', favorites[0].text.strip)
       assert_equal('/var', favorites[1].text.strip)
@@ -1396,7 +1396,7 @@ def make_bc_app(dir, form)
       click_on('Select Path')
 
       # favorites that have been configured in yml
-      favorites = all('#favorites li', wait: 30)
+      favorites = get_favorites
       assert_equal(2, favorites.size)
       assert_equal('/fs/ess', favorites[0].text.strip)
       assert_equal('/fs/scratch', favorites[1].text.strip)
@@ -1433,11 +1433,19 @@ def make_bc_app(dir, form)
       click_on('Select Path')
 
       # no favorites show up
-      favorites = all('#favorites li', wait: 30)
+      favorites = get_favorites
       assert_equal(0, favorites.size)
     end
   end
 
+  def get_favorites
+    # For debugging flaky tests
+    favorites = all('#favorites li', wait: 30)
+    puts "FAVORITES: "
+    puts favorites.map{|i| i['innerHTML']}.join('')
+    favorites
+  end
+
   test 'saves settings as a template' do
     with_modified_env({ ENABLE_NATIVE_VNC: 'true', OOD_BC_SAVED_SETTINGS: 'true' }) do
       Dir.mktmpdir do |dir|