Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom JS feature #2791

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented May 1, 2023

Added support to include custom JS files from the public directory within OOD installation.
This is based on the custom CSS feature already supported.

Fixes #2786

Given a configuration with the property:

custom_javascript_files: ["/tracking.js", "/custom/team1.js"]

Will generate the following script tags in the application.html.erb layout after the application js is loaded

<script src="/public/tracking.js" nonce="MZQL48piRTXHshPRhUhqKBkxtLww"></script>
<script src="/public/custom/team1.js" nonce="MZQL48piRTXHshPRhUhqKBkxtLww"></script>

┆Issue is synchronized with this Asana task by Unito

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@johrstrom johrstrom merged commit 0e997eb into OSC:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom JS files
3 participants